EHCI Isoc questinos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dave:

ehci_iso_stream->rescheduled and ->start seem never to get used.  In
fact I can't even tell what ->rescheduled is supposed to count, since
it doesn't get incremented.  Should they be removed?

The BUG_ON that's commented out of itd_patch() can actually be 
triggered if somebody submits an URB with a sufficiently discontiguous 
list of packet offsets.  Without the BUG_ON, the result is memory 
corruption.  There's a comment about the offsets being strictly 
increasing, but that's not enough to prevent the bug.  Neither 
requirement is documented, so what should we do about this?

Alan Stern

P.S.: I have a series of patches to clean up the Clear-TT-Buffer stuff.  
The buffer is cleared after any problem (as required by the USB spec), 
not just those that leave a CSPLIT pending.  Any objection?

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux