RE: [PATCH 004/004] [RESUBMIT2] USB: serial: sierra driver interface blacklisting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: greg.n.banks@xxxxxxxxx [mailto:greg.n.banks@xxxxxxxxx] On Behalf
> Of Greg Banks
> Sent: Wednesday, May 20, 2009 2:22 PM
> To: Rory Filer
> Cc: Greg KH; linux-usb@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 004/004] [RESUBMIT2] USB: serial: sierra driver
> interface blacklisting
> 
> G'day,
> 


<SNIP>

> 
> > So I would request that you retract your patch
> 
> Consider my patch retracted.  GregKH, sorry for the waste of time and
> the whitespace damage :-)

Great, thanks. 

> >
> > Your patch will work, but not completely. It requires additional
> logic to blacklist some of the interfaces exposed by the USB
> descriptor.
> 
> Ok.  Just idly curious now, but why would you blacklist the storage
> interface at 9?

The blacklist is there to make sure the sierra.c driver, which is a serial driver, 
does not claim interfaces which are not serial. The USB descriptor for interface 9 contains bDeviceClass, bDeviceSubClass, etc, fields indicating it is a mass storage 
device, so the O/S will take care of it automatically. Other interfaces in that 
list are claimed by our new directIP driver which is coming to our KB page soon.

> 
> which is what I managed to dig up in a few moments of googling.  That
> appears to be older information, you might want to update or remove
> it.  However I note that neither page mentions the 306 or 307 as
> supported devices.

Hmmm thanks. Google can be a mischief maker sometimes. In this case it would have
been better to search our KB site. I'll talk to tech support about whether it's
time to pull down that offending page. 

That problem should be fixed in the coming week or so when we add a new page
especially for the USB 306 and MC8700 modems. They both will use the direct IP
driver and the sierra.c driver.

NOTE, we are anxiously awaiting the approval of some 9 outstanding patches in 
2 series. After that we have one more series of 3 patches to submit and then 
the kernel will be up-to-date with our KB page where you will find the driver
version is 1.7.0 for kernels 2.6.20 and up.

> 
> --
> Greg.

Hi Greg, 

I've embedded some comments in the forerunning text. Some day I'll maybe get used
to this "backward" email format :-)

Regards, 

Rory

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux