Re: [PATCH 05/34] lsusb.py: remove -w (warn if usb.ids not sorted) option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 6, 2019 at 2:13 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, May 06, 2019 at 12:02:12PM +0300, Mantas Mikulėnas wrote:
> > Signed-off-by: Mantas Mikulėnas <grawity@xxxxxxxxx>
> > ---
> >  lsusb.py.in | 45 ++-------------------------------------------
> >  1 file changed, 2 insertions(+), 43 deletions(-)
>
> Why remove this?  What's wrong with this option for people who want to
> work on usb.ids?


Hmm, I was under the impression that its purpose was just for
debugging the lookup code and becomes unnecessary when said lookup
code is outright removed (the next commit removes the binary-search
lookup). Did I misunderstand the code?

(Although in any case, a dedicated "lint-usb.ids" script seems like a
more fitting place for this feature than a lsusb option...)

-- 
Mantas Mikulėnas




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux