On Fri, May 03, 2019 at 03:28:04PM +0800, Charles Yeh wrote: > Johan Hovold <johan@xxxxxxxxxx> 於 2019年5月3日 週五 下午3:11寫道： > > What changed in v2? You forgot to add a changelog here. > > > > Looks like this one is not based on the current driver code (e.g. my > > usb-next branch as we discussed), and also does not address some of the > > issues raised so far (e.g. you're overwriting the entire flow control > > register on updates). > > > > I used the Kernel tree: > git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git > > but the pl2303.c inside does not have the "pl2303_update_reg" you mentioned. Perhaps you did not use the usb-next branch? That branch has the following commit: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=f64c3ab230682e8395a7fbd01f3eb5140c837d4e which adds the helper. Johan
