Re: [PATCH 2/3] usb: usb251xb: Create a ports field collector method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 24/04/2019 23:12, Serge Semin wrote:
Seeing the ports field collection functionality is used four times per
just one function, it's better to have a dedicated method performing
the task. Note that this fix filters the port 0 out from the lanes
swapping property the same way as it has been programmed for the rest
multi-ports properties. But unlike the rest of ports config registers
the BIT(0) of the Port Lanes Swap register refers to the Upstream Port
lanes inversion. This fact hasn't been documented in the driver bindings
nor there were any mentioning about port 0 being treated as upstream
port. Lets then leave this fix as is for the properties unification
and create an additional "swap-us-lanes" in the next patch.

Signed-off-by: Serge Semin <fancer.lancer@xxxxxxxxx>
---
  drivers/usb/misc/usb251xb.c | 71 ++++++++++++++-----------------------
  1 file changed, 26 insertions(+), 45 deletions(-)


Acked-by: Richard Leitner <richard.leitner@xxxxxxxxxxx>



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux