On 05/11/2009 11:46 PM, Greg KH wrote:
> On Mon, May 11, 2009 at 05:48:55PM +0200, Jiri Slaby wrote:
>> Here comes some of my comments to the rest:
>>
>> +#define debug(format, arg...) pr_debug("hid-sjoyff: " format "\n" , ## arg)
>>
>> Define pr_fmt instead of this.
>
> No, please use dev_dbg() instead of creating a new macro.
No, unfortunately there is no struct device available in the two
functions he uses this macro in.
It should look like
#define pr_fmt(fmt) "hid-sjoyff: " fmt "\n"
and then use pr_debug as usual.
In other places he correctly uses dev_* stuff.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
