Re: [PATCH] hid: add force feedback support for SmartJoy PLUS PS2/USB adapter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 11, 2009 at 05:48:55PM +0200, Jiri Slaby wrote:
> Here comes some of my comments to the rest:
> 
> +#define debug(format, arg...) pr_debug("hid-sjoyff: " format "\n" , ## arg)
> 
> Define pr_fmt instead of this.

No, please use dev_dbg() instead of creating a new macro.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux