On Sa, 2019-03-02 at 15:36 +0100, Greg Kroah-Hartman wrote: > On Sat, Mar 02, 2019 at 02:51:41PM +0100, Oliver Neukum wrote: > > On Sa, 2019-03-02 at 09:00 +0100, Greg Kroah-Hartman wrote: > > > On Fri, Mar 01, 2019 at 08:44:13PM +0100, Oliver Neukum wrote: > > > > On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote: > > > > > By moving one field around in 'struct urb' we reduce the size of the > > > > > structure by 8 bytes. > > > > > > > > If you are going for this I have to ask why unlink and status > > > > are full size ints anyway. > > > > > > History, they hold a "normal" negative error code. I guess we could > > > turn them into s16, if it really matters, but that feels odd to me. > > > > Returning internal error codes to user space is a bug. > > Where does status and unlink end up going to userspace? Maybe through > usbfs? Nowhere, I hope. Sorry for the confusion. I hope I fixed that some time ago. My point here is that using the external errnos for internal error report is not an advantage. In fact, it is a bad idea. A byte would be ample to record internal errors. Regards Oliver
