Re: [PATCH] USB: usb.h: tweak struct urb to remove wasted space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sa, 2019-03-02 at 09:00 +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 01, 2019 at 08:44:13PM +0100, Oliver Neukum wrote:
> > On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote:
> > > By moving one field around in 'struct urb' we reduce the size of the
> > > structure by 8 bytes.
> > 
> > If you are going for this I have to ask why unlink and status
> > are full size ints anyway.
> 
> History, they hold a "normal" negative error code.  I guess we could
> turn them into s16, if it really matters, but that feels odd to me.

Returning internal error codes to user space is a bug.

	Regards
		Oliver




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux