Re: [PATCH] usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Minas Harutyunyan <minas.harutyunyan@xxxxxxxxxxxx> writes:
> Hi Greg, Filipe,
>
> On 12/12/2018 4:44 PM, Minas Harutyunyan wrote:
>> To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register
>> require to write 1. This bit is implemented as "Write to clear".
>> 
>> Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert
>> interrupt")
>> 
>> Signed-off-by: Minas Harutyunyan <hminas@xxxxxxxxxxxx>
>> ---
>>   drivers/usb/dwc2/gadget.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
>> index 68ad75a7460d..55ef3cc2701b 100644
>> --- a/drivers/usb/dwc2/gadget.c
>> +++ b/drivers/usb/dwc2/gadget.c
>> @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
>>   
>>   	if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
>>   		dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
>> -		dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
>> +		dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
>>   		dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG);
>>   	}
>>   }
>> 
>
> Sorry for last minute fix of this stupid bug.
> Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert 
> interrupt handler."

And where is that?

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux