> -----Original Message----- > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb- > owner@xxxxxxxxxxxxxxx] On Behalf Of Hans de Goede > Sent: Monday, January 7, 2019 4:20 PM > To: Balaji, M <m.balaji@xxxxxxxxx>; linux-usb@xxxxxxxxxxxxxxx > Cc: mathias.nyman@xxxxxxxxxxxxxxx; heikki.krogerus@xxxxxxxxxxxxxxx > Subject: Re: [PATCH V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on > INTEL_SUNRISEPOINT_LP_XHCI > > Hi, > > On 08-01-19 11:04, m.balaji@xxxxxxxxx wrote: > > From: M, Balaji <m.balaji@xxxxxxxxx> > > > > This fix enables USB role feature on intel commercial nuc > > platform which is based on Kabylake chipset. > > > > Signed-off-by: M, Balaji <m.balaji@xxxxxxxxx> > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > --- > > Changes from v1: Added Reviewed-by > > There is no need to send out a v2 just to add a Reviewed-by, > the subsys-maintainer will pick the Reviewed-by up when merging. > > If you need to do a v2 to add some other minor change adding the > Reviewed-by is fine. > > Regards, > > Hans Hello Hans , Sure got it , thanks Will take care next time . Regards , Balaji > > > > drivers/usb/host/xhci-pci.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > > index a9ec7051f286..c2fe218e051f 100644 > > --- a/drivers/usb/host/xhci-pci.c > > +++ b/drivers/usb/host/xhci-pci.c > > @@ -194,6 +194,7 @@ static void xhci_pci_quirks(struct device *dev, struct > xhci_hcd *xhci) > > xhci->quirks |= XHCI_SSIC_PORT_UNUSED; > > if (pdev->vendor == PCI_VENDOR_ID_INTEL && > > (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI || > > + pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI || > > pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI)) > > xhci->quirks |= XHCI_INTEL_USB_ROLE_SW; > > if (pdev->vendor == PCI_VENDOR_ID_INTEL && > >
