On Tue, Jan 08, 2019 at 05:04:20AM -0500, m.balaji@xxxxxxxxx wrote: > From: M, Balaji <m.balaji@xxxxxxxxx> > > This fix enables USB role feature on intel commercial nuc > platform which is based on Kabylake chipset. > > Signed-off-by: M, Balaji <m.balaji@xxxxxxxxx> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> OK by me: Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> Do not send an other version where you add just that tag! Mathias, as the maintainer, will take care of adding the tag to the commit. > --- > Changes from v1: Added Reviewed-by > drivers/usb/host/xhci-pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > index a9ec7051f286..c2fe218e051f 100644 > --- a/drivers/usb/host/xhci-pci.c > +++ b/drivers/usb/host/xhci-pci.c > @@ -194,6 +194,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) > xhci->quirks |= XHCI_SSIC_PORT_UNUSED; > if (pdev->vendor == PCI_VENDOR_ID_INTEL && > (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI || > + pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI || > pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI)) > xhci->quirks |= XHCI_INTEL_USB_ROLE_SW; > if (pdev->vendor == PCI_VENDOR_ID_INTEL && > -- > 2.17.1 thanks, -- heikki