On Mon, May 4, 2009 at 11:41 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Sun, 3 May 2009, Sean Hildebrand wrote: > >> Bingo. Added that quirk to modprobe.conf and now the joystick works on >> boot. Any idea why the joystick worked in 2.6.28 and earlier after >> being unplugged and plugged back in, but stopped working in 2.6.29? > > No, not really. > >> Also, does a list of device IDs that require certain quirks make its >> way upstream or will I need to keep a line in modprobe.conf for the >> foreseeable future? > > Here is a patch to add your device ID, eliminating the need for a > special line in modprobe.conf. Try it out, and if it works I will > submit it upstream. > > Alan Stern > > > > Index: usb-2.6/drivers/hid/hid-ids.h > =================================================================== > --- usb-2.6.orig/drivers/hid/hid-ids.h > +++ usb-2.6/drivers/hid/hid-ids.h > @@ -113,6 +113,9 @@ > #define USB_VENDOR_ID_BERKSHIRE 0x0c98 > #define USB_DEVICE_ID_BERKSHIRE_PCWD 0x1140 > > +#define USB_VENDOR_ID_CH 0x068e > +#define USB_DEVICE_ID_CH_COMBATSTICK 0x00f4 > + > #define USB_VENDOR_ID_CHERRY 0x046a > #define USB_DEVICE_ID_CHERRY_CYMOTION 0x0023 > > Index: usb-2.6/drivers/hid/usbhid/hid-quirks.c > =================================================================== > --- usb-2.6.orig/drivers/hid/usbhid/hid-quirks.c > +++ usb-2.6/drivers/hid/usbhid/hid-quirks.c > @@ -50,6 +50,7 @@ static const struct hid_blacklist { > { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_2PORTKVM, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_4PORTKVM, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_4PORTKVMC, HID_QUIRK_NOGET }, > + { USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_COMBATSTICK, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET }, > > Gave it a shot, works as it should. It's likely that the entire CH Products line-up requires this quirk, but I only have the Combatstick so I can't confirm. Thanks for the quick fix. Sean Hildebrand -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html