On 1/4/19 2:24 PM, Andrew Lunn wrote: >>> All this crossover code should be moved into the PHY driver. >> >> Fine, this can be done in a subsequent patch though, right ? I'd like to >> keep the changes small, so if something breaks, it could be bisected easily. > > Hi Marek Hi, > The problem is, do you have a regression because of the changes you > made here, or because you have two things controlling the PHY, the MAC > driver and the PHY driver, which are not coordinating? > > I don't know if you can do a piecemeal conversation like this. I don't > remember anybody else doing anything like this before. I'd prefer that. > What you can do piecemeal is add new functionality to the existing PHY > driver. If you break the PHY driver we can then bisect it to find out > which change broke it. Once the PHY driver has everything you need, > then swap the MAC driver to use phylib. I wonder, if I use the phylib functions instead of the ad-hoc ones in the MAC driver, is there still a problem with synchronization ? -- Best regards, Marek Vasut
