On Thu, Dec 27, 2018 at 07:34:25PM +0800, liquid wrote: > It's a PS3 "clone" joystick. Everything works fine EXCEPT rumbling. > > I think it's related to commit > 492ca83c3d19fba1622164f07cd7b775596a7db2 (HID: sony: Fix SHANWAN pad > rumbling on USB ) . If I revert this commit, the controller starts to > rumble as soon as plugged in, > indicated this joystick is, in fact, capable of rumbling after all. Oh good (adding those authors to the cc: list). But reverting that commit is not ok, you don't need rumbling to happen all the time :) > PS: I also noticed four leds of this controller start to blink after > plugged in. But in windows, only one LED toggle on without blinking. As it is a "clone" odds are it needs some kind of quirk to get the rest of it to work properly. Bastien, any ideas about this? thanks, greg k-h