RE: [PATCH] usb: chipidea: add a check for the availability of next child

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 
> Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>
> ---
>  drivers/usb/chipidea/ci_hdrc_msm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c
> b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 880009987460..7dc987b4036a 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> @@ -250,6 +250,8 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
>  	ulpi_node = of_get_child_by_name(pdev->dev.of_node, "ulpi");
>  	if (ulpi_node) {
>  		phy_node = of_get_next_available_child(ulpi_node, NULL);
> +		if (!phy_node)
> +			dev_err(&pdev->dev, "no child nodes found\n");
>  		ci->hsic = of_device_is_compatible(phy_node, "qcom,usb-hsic-phy");
>  		of_node_put(phy_node);
>  	}

With "ulpi" node, but phy node is not found, I assume the controller can't work properly, we may need to
return error value.  Add loic to confirm.

Peter





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux