Re: [PATCH 09/23] Add USB 3.0 roothub support to USB core.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Viral Mehta wrote:


+
/*-------------------------------------------------------------------------*/ /* @@ -426,7 +488,9 @@ static int rh_call_control (struct usb_hcd *hcd, struct urb *urb)
     case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
         switch (wValue & 0xff00) {
         case USB_DT_DEVICE << 8:
-            if (hcd->driver->flags & HCD_USB2)
+            if (hcd->driver->flags & HCD_USB3)
+                bufp = usb3_rh_dev_descriptor;
+            else if (hcd->driver->flags & HCD_USB2)
                 bufp = usb2_rh_dev_descriptor;
             else if (hcd->driver->flags & HCD_USB11)
                 bufp = usb11_rh_dev_descriptor;
I think better to replace "if ... else if... else" with switch case as you did in patch [06/23]
You think its not a good idea ? or you want me to drop a patch to do this ?

--
Thanks,
Viral Mehta, Embedded Software Engineer, www.einfochips.com
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux