Re: [PATCH 2/5] USB: Provide USB boot device availability notification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 30, 2009 at 03:24:30PM -0400, Alan Stern wrote:
> On Thu, 30 Apr 2009, Sergei Shtylyov wrote:
> 
> > Alan Stern wrote:
> > 
> > >>>+/* The mask of possible USB boot devices depends on what drivers and
> > >>>+ * options have been configured into the kernel.  There are too many
> > >>>+ * USB network config options to list here, so just assume it is always
> > >>>+ * possible to have a USB network device.
> > >>>+ */
> > >>>+static int usb_bootdev_mask = 0
> > >>>+#ifdef CONFIG_USB_SERIAL_CONSOLE
> > >>>+				| BOOTDEV_CONSOLE_MASK
> > >>>+#endif
> > >>>+#if defined(CONFIG_USB_STORAGE) | defined(CONFIG_BLK_DEV_UB)
> > 
> > >>    It should be ||, not bitwise | here, no?
> > 
> > > No, it should be bitwise |.  The value being constructed is a union of 
> > > disjoint mask bits.
> > 
> >     I meant the #if line only. Although it shouldn't matter really...
> 
> Oh, sorry.  Yes, you're right about that (and you're right that it 
> doesn't really matter...).
> 
> David, you can go ahead and change the patch, but don't bother to
> submit a new version for such a small thing.  The next time this gets 
> pushed it'll have the right operator.

Done. It will be in the next submission.

> Alan Stern

David VomLehn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux