On 12/11/18 13:03, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rogerq@xxxxxx> writes: >>>> Also can we have some consistency in usage of '-' vs '_'? >>> Right.. I agree. I've been using '-' as it is the preferred syntax as >>> most of the properties, but some old properties use '_'. Do you have any >>> suggestion? >> >> I'd keep it consistent to "snps,usb3_lpm_capable" so we avoid mistakes >> when writing the DT. >> Felipe? > > _ are not really accepted in DT, except for legacy properties. What we > can do is rename usb3_lpm_capable to usb3-lpm-capable and change code to > try with _ if - fails. Then we can introduce the new property using - > I agree. This is a better approach. cheers, -roger -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki