On Mo, 2018-10-08 at 17:10 +0300, Igor Russkikh wrote: > Hi Oliver, > > > > + aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_MAJOR, > > > + 1, 1, &aqc111_data->fw_ver.major); > > > + aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_MINOR, > > > + 1, 1, &aqc111_data->fw_ver.minor); > > > + aqc111_read_cmd(dev, AQ_ACCESS_MAC, AQ_FW_VER_REV, > > > + 1, 1, &aqc111_data->fw_ver.rev); > > > > Why read the stuff you don't need? > > fw_ver is used below to determine phy access mode. > > fw_ver.rev is not used in this exact patch, thats true, > but it gets reported in later patches in the set. Hi, OK that makes sense. Regards Oliver
