On Fr, 2018-10-05 at 10:24 +0000, Igor Russkikh wrote: > This patchset introduces support for new multigig ethernet to USB dongle, > developed jointly by Aquantia (Phy) and ASIX (USB MAC). > > The driver has similar structure with other ASIX MAC drivers (AX88179), but > with a number of important differences: > - Driver supports both direct Phy and custom firmware interface for Phy > programming. This is due to different firmware modules available with this > product. > - Driver handles new 2.5G/5G link speed configuration and reporting. > - Device support all speeds from 100M up to 5G. > - Device supports MTU up to 16K. > > Device supports various standard networking features, like > checksum offloads, vlan tagging/filtering, TSO. > > The code of this driver is based on original ASIX sources and was extended > by Aquantia for 5G multigig support. Thank you for the driver. It is good to see drivers for cool hardware. Unfortunately there have been a few issues I have tried to point out in reviews. Please fix them and resubmit. Regards Oliver