> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Friday, September 07, 2018 12:49 PM > To: Gopal, Saranya <saranya.gopal@xxxxxxxxx> > Cc: linux-usb@xxxxxxxxxxxxxxx; heikki.krogerus@xxxxxxxxxxxxxxx; Kuppuswamy, > Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxx>; K V, Abhilash > <abhilash.k.v@xxxxxxxxx>; Balaji, M <m.balaji@xxxxxxxxx> > Subject: Re: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform > > On Fri, Sep 07, 2018 at 12:32:01PM +0530, saranya.gopal@xxxxxxxxx wrote: > > From: Saranya Gopal <saranya.gopal@xxxxxxxxx> > > > > This patch adds static DRD mode for host/device > > mode switch. This fixes the issue where device > > mode was not working after DUT switches to host > > mode with 3.0 OTG connector. > > > > Signed-off-by: Saranya Gopal <saranya.gopal@xxxxxxxxx> > > Signed-off-by: M Balaji <m.balaji@xxxxxxxxx> > > Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > Reviewed-by: Kuppuswamy Sathyanarayanan > <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> > > --- > > changes since V5: Corrected the name format in From and Signed-off-by > > changes since V4: Removed change-Id > > changes since V3: Added Reviewed-by Sathyanarayanan tag > > changes since V2: Incorporated Heikki's review comments and added > Reviewed-by Heikki tag > > changes since V1: none > > > > drivers/usb/roles/intel-xhci-usb-role-switch.c | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c > b/drivers/usb/roles/intel-xhci-usb-role-switch.c > > index dad2d19..0d1ea82 100644 > > --- a/drivers/usb/roles/intel-xhci-usb-role-switch.c > > +++ b/drivers/usb/roles/intel-xhci-usb-role-switch.c > > @@ -25,6 +25,9 @@ > > #define SW_VBUS_VALID BIT(24) > > #define SW_IDPIN_EN BIT(21) > > #define SW_IDPIN BIT(20) > > +#define SW_SWITCH_EN_CFG0 BIT(16) > > Why is this not in the correct sorted order with the items above it? I added only the last one. Do you want me to sort the existing macros in BIT sorted order? > > Is this a patch that should go to the stable trees? If so, which ones? It is not applicable to any stable tree. Thanks, Saranya > > thanks, > > greg k-h
