Hi Shimoda-San,
Thanks for the feedback.
> Subject: RE: [PATCH] usb: host: xhci-rcar: Add support for r8a774a1
>
> Hi Biju-san,
>
> Thank you for the patch!
>
> > From: Biju Das, Sent: Friday, August 24, 2018 7:17 PM
> >
> > This patch adds support for r8a774a1 (RZ/G2M).
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > ---
> > drivers/usb/host/xhci-rcar.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-rcar.c
> > b/drivers/usb/host/xhci-rcar.c index f33ffc2..c906b13 100644
> > --- a/drivers/usb/host/xhci-rcar.c
> > +++ b/drivers/usb/host/xhci-rcar.c
> > @@ -72,6 +72,10 @@
> MODULE_FIRMWARE(XHCI_RCAR_FIRMWARE_NAME_V3);
> >
> > static const struct soc_device_attribute rcar_quirks_match[] = {
> > {
> > +.soc_id = "r8a774a1",
> > +.data = (void *)RCAR_XHCI_FIRMWARE_V3,
> > +},
> > +{
>
> I also don't think you need this patch actually because you submitted adding
> a bindings patch for usb-xhci [1] and it had "renesas,rcar-gen3-xhci" for
> RZ/G2.
> In other words, if a xhci node of RZ/G2 dtsi has "renesas,rcar-gen3-xhci"
> compatible, this can probe the xhci-plat/rcar driver with the firmware V3.
I agree. We don't need this patch, after the introduction of ed8603e11124
(" usb: host: xhci-rcar: Simplify getting the firmware name for R-Car Gen3") and fc72aa83b4a7
("usb: host: xhci-plat: add firmware_name for R-Car Gen3") which is present in renesas-devel-20180827-4.19-rc1.
This above patch was missing in our internal development branch which is based on renesas-dev-20180810.
> [1]
> https://patchwork.kernel.org/patch/10574887/
>
> Best regards,
> Yoshihiro Shimoda
>
> > .soc_id = "r8a7795", .revision = "ES1.*",
> > .data = (void *)RCAR_XHCI_FIRMWARE_V2,
> > },
> > --
> > 2.7.4
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
