RE: [PATCH] usb: host: xhci-rcar: Add support for r8a774a1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju-san,

Thank you for the patch!

> From: Biju Das, Sent: Friday, August 24, 2018 7:17 PM
> 
> This patch adds support for r8a774a1 (RZ/G2M).
> 
> Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> ---
>  drivers/usb/host/xhci-rcar.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-rcar.c b/drivers/usb/host/xhci-rcar.c
> index f33ffc2..c906b13 100644
> --- a/drivers/usb/host/xhci-rcar.c
> +++ b/drivers/usb/host/xhci-rcar.c
> @@ -72,6 +72,10 @@ MODULE_FIRMWARE(XHCI_RCAR_FIRMWARE_NAME_V3);
> 
>  static const struct soc_device_attribute rcar_quirks_match[]  = {
>  	{
> +		.soc_id = "r8a774a1",
> +		.data = (void *)RCAR_XHCI_FIRMWARE_V3,
> +	},
> +	{

I also don't think you need this patch actually because
you submitted adding a bindings patch for usb-xhci [1]
and it had "renesas,rcar-gen3-xhci" for RZ/G2.
In other words, if a xhci node of RZ/G2 dtsi has "renesas,rcar-gen3-xhci" compatible,
this can probe the xhci-plat/rcar driver with the firmware V3.

[1]
https://patchwork.kernel.org/patch/10574887/

Best regards,
Yoshihiro Shimoda

>  		.soc_id = "r8a7795", .revision = "ES1.*",
>  		.data = (void *)RCAR_XHCI_FIRMWARE_V2,
>  	},
> --
> 2.7.4





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux