On 7/26/2018 2:32 PM, Andy Shevchenko wrote: > On Thu, Jul 26, 2018 at 11:52 PM, Thinh Nguyen > <Thinh.Nguyen@xxxxxxxxxxxx> wrote: >> dwc_usb31 does not support OTG mode. If the controller supports DRD but >> the dr_mode is not specified or set to OTG, then set the mode to >> peripheral. >> >> Signed-off-by: Thinh Nguyen <thinhn@xxxxxxxxxxxx> >> --- >> drivers/usb/dwc3/core.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >> index 21e4931d0cc0..64ba664d467c 100644 >> --- a/drivers/usb/dwc3/core.c >> +++ b/drivers/usb/dwc3/core.c >> @@ -78,6 +78,14 @@ static int dwc3_get_dr_mode(struct dwc3 *dwc) >> mode = USB_DR_MODE_HOST; >> else if (IS_ENABLED(CONFIG_USB_DWC3_GADGET)) >> mode = USB_DR_MODE_PERIPHERAL; >> + >> + /* >> + * dwc_usb31 does not support OTG mode. If the controller >> + * supports DRD but the dr_mode is not specified or set to OTG, >> + * then set the mode to peripheral. >> + */ >> + if (mode == USB_DR_MODE_OTG && dwc3_is_usb31(dwc)) > shouldn't be simple > > else if (dwc3_is_usb31(...)) > > ? Yes you're right. :) Thanks, Thinh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
