Re: [PATCH] usb: dwc3: Set default mode for dwc_usb31

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 26, 2018 at 11:52 PM, Thinh Nguyen
<Thinh.Nguyen@xxxxxxxxxxxx> wrote:
> dwc_usb31 does not support OTG mode. If the controller supports DRD but
> the dr_mode is not specified or set to OTG, then set the mode to
> peripheral.
>
> Signed-off-by: Thinh Nguyen <thinhn@xxxxxxxxxxxx>
> ---
>  drivers/usb/dwc3/core.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 21e4931d0cc0..64ba664d467c 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -78,6 +78,14 @@ static int dwc3_get_dr_mode(struct dwc3 *dwc)
>                         mode = USB_DR_MODE_HOST;
>                 else if (IS_ENABLED(CONFIG_USB_DWC3_GADGET))
>                         mode = USB_DR_MODE_PERIPHERAL;
> +
> +               /*
> +                * dwc_usb31 does not support OTG mode. If the controller
> +                * supports DRD but the dr_mode is not specified or set to OTG,
> +                * then set the mode to peripheral.
> +                */

> +               if (mode == USB_DR_MODE_OTG && dwc3_is_usb31(dwc))

shouldn't be simple

else if (dwc3_is_usb31(...))

?

> +                       mode = USB_DR_MODE_PERIPHERAL;
>         }
>
>         if (mode != dwc->dr_mode) {
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux