Re: Incorrect PID in drivers/usb/serial/kl5kusb105.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 04, 2018 at 05:18:34PM +0100, Chris Jakob wrote:
> Thanks.
> Apologies I may have been a little premature as the device still does
> not seem to be working (although it is now recognised)
> 
> dmesg provides:
> [    6.864734] kl5kusb105: loading out-of-tree module taints kernel.
> [    6.864827] kl5kusb105: module verification failed: signature and/or required key missing - tainting kernel
> [    6.865276] usbcore: registered new interface driver kl5kusb105
> [    6.865311] usbserial: USB Serial support registered for KL5KUSB105D / PalmConnect
> [    6.865352] kl5kusb105 2-1.2:1.0: KL5KUSB105D / PalmConnect converter detected
> [    6.868735] usb 2-1.2: KL5KUSB105D / PalmConnect converter now attached to ttyUSB0
> [    6.897271] usb 3-2: pl2303 converter now attached to ttyUSB1
> [    7.779557] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> [    7.849385] r8169 0000:02:00.0 eth0: link down
> [    7.849388] r8169 0000:02:00.0 eth0: link down
> [    7.849487] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> [    8.774276] kl5kusb105d ttyUSB0: Change port settings failed (error = -32)
> [    8.774289] usb 2-1.2: 5 byte block, baudrate 6, databits 8, u1 0, u2 1
> [    8.774778] kl5kusb105d ttyUSB0: Enabling read failed (error = -32)
> [    8.776142] kl5kusb105d ttyUSB0: Change port settings failed (error = -32)
> [    8.776152] usb 2-1.2: 5 byte block, baudrate 6, databits 8, u1 0, u2 1
> [    8.776527] kl5kusb105d ttyUSB0: Enabling read failed (error = -32)
> [    8.777904] kl5kusb105d ttyUSB0: Change port settings failed (error = -32)
> [    8.777913] usb 2-1.2: 5 byte block, baudrate 6, databits 8, u1 0, u2 1
> [    8.778275] kl5kusb105d ttyUSB0: Enabling read failed (error = -32)
> [    8.779639] kl5kusb105d ttyUSB0: Change port settings failed (error = -32)
> [    8.779648] usb 2-1.2: 5 byte block, baudrate 6, databits 8, u1 0, u2 1
> [    8.780004] kl5kusb105d ttyUSB0: Enabling read failed (error = -32)
> [    8.781387] kl5kusb105d ttyUSB0: Change port settings failed (error = -32)
> [    8.781396] usb 2-1.2: 5 byte block, baudrate 6, databits 8, u1 0, u2 1
> [    8.781755] kl5kusb105d ttyUSB0: Enabling read failed (error = -32)
> 
> It may be that my device is not working properly or I have incorrectly
> built/installed the driver (not my area of expertise) rebooting has
> had no effect

I'm afraid the answer is just that the driver does not appear to support
kl5kusb105 the device is is named after. Those -EPIPE (-32) errors above
indicates that the device does not recognise the protocol currently
implemented and the driver consequently aborts any open attempts.

If you take look at the file header:

 * It seems that KLSI bought some silicon-design information from ScanLogic,
 * whose SL11R processor is at the core of the KL5KUSB chipset from KLSI.
 * KLSI has firmware available for their devices; it is probable that the
 * firmware differs from that used by KLSI in their products. If you have an
 * original KLSI device and can provide some information on it, I would be
 * most interested in adding support for it here. If you have any information
 * on the protocol used (or find errors in my reverse-engineered stuff), please
 * let me know.
 *
 * The code was only tested with a PalmConnect USB adapter; if you
 * are adventurous, try it with any KLSI-based device and let me know how it
 * breaks so that I can fix it!

that seems to imply that the driver has never been tested with a KLSI
device and that firmware differences could be expected. The device id
typo, and your tests seems to confirm all of this.

> Hopefully this is now in plain text…unless mac mail decides otherwise :(

Yep, that worked.

Unless you have access to a vendor driver and are in the mood of reverse
engineering the protocol, I'm afraid there's not much we can do here. I
should probably just remove the (incorrect) device-id entry as well.

Thanks,
Johan


> lsusb -v as follows:

> Bus 002 Device 003: ID 05e9:000c Kawasaki LSI USB-to-RS-232
> Device Descriptor:
>   bLength                18
>   bDescriptorType         1
>   bcdUSB               1.00
>   bDeviceClass          255 Vendor Specific Class
>   bDeviceSubClass         0 
>   bDeviceProtocol         0 
>   bMaxPacketSize0         8
>   idVendor           0x05e9 Kawasaki LSI
>   idProduct          0x000c USB-to-RS-232
>   bcdDevice            1.01
>   iManufacturer           1 (error)
>   iProduct                2 (error)
>   iSerial                 3 (error)
>   bNumConfigurations      1
>   Configuration Descriptor:
>     bLength                 9
>     bDescriptorType         2
>     wTotalLength           39
>     bNumInterfaces          1
>     bConfigurationValue     1
>     iConfiguration          0 
>     bmAttributes         0x80
>       (Bus Powered)
>     MaxPower               94mA
>     Interface Descriptor:
>       bLength                 9
>       bDescriptorType         4
>       bInterfaceNumber        0
>       bAlternateSetting       0
>       bNumEndpoints           3
>       bInterfaceClass       255 Vendor Specific Class
>       bInterfaceSubClass      0 
>       bInterfaceProtocol      0 
>       iInterface              0 
>       Endpoint Descriptor:
>         bLength                 7
>         bDescriptorType         5
>         bEndpointAddress     0x81  EP 1 IN
>         bmAttributes            2
>           Transfer Type            Bulk
>           Synch Type               None
>           Usage Type               Data
>         wMaxPacketSize     0x0040  1x 64 bytes
>         bInterval               0
>       Endpoint Descriptor:
>         bLength                 7
>         bDescriptorType         5
>         bEndpointAddress     0x02  EP 2 OUT
>         bmAttributes            2
>           Transfer Type            Bulk
>           Synch Type               None
>           Usage Type               Data
>         wMaxPacketSize     0x0040  1x 64 bytes
>         bInterval               0
>       Endpoint Descriptor:
>         bLength                 7
>         bDescriptorType         5
>         bEndpointAddress     0x83  EP 3 IN
>         bmAttributes            3
>           Transfer Type            Interrupt
>           Synch Type               None
>           Usage Type               Data
>         wMaxPacketSize     0x0008  1x 8 bytes
>         bInterval               1
> Device Status:     0x28b0
>   (Bus Powered)

> On 4 Jul 2018, at 16:09, Johan Hovold <johan@xxxxxxxxxx> wrote:
> 
> [ Please avoid using html when posting the lists. Including full mail
>  below in case this did not reach the list. ]
> 
> On Wed, Jul 04, 2018 at 03:05:24PM +0100, Chris Jakob wrote:
> The PID definitions fro VID 05e9 are listed in
> http://www.linux-usb.org/usb.ids as:
> 
> 
> 05e9  Kawasaki LSI
> 	0008  KL5KUSB101B Ethernet [klsi]
> 	0009  Sony 10Mbps Ethernet [pegasus]
> 	000c  USB-to-RS-232
> 	000d  USB-to-RS-232
> 	0014  RS-232 J104
> 	0040  Ethernet Adapter
> 	2008  Ethernet Adapter
> 
> 
> However  drivers/usb/serial/kl5kusb105.h defines the following:
> 
> #define  KLSI_KL5KUSB105D_PID 0x00c0
> 
> My KLSI serial adapter is not recognized with the current kernel, however
> if I rebuild KL5KUSB105 with
> 
> #define  KLSI_KL5KUSB105D_PID 0x000c
> 
> the serial adapter is recognized.
> 
> So my hardware matches the definitions in  http://www.linux-usb.org/usb.ids.
> 
> Can this be changed for future kernels?
> 
> Absolutely, and we should probably fix that in the active stable trees
> as well.
> 
> Could just provide the output of usb-devices (or lsusb -v) for your
> device for future reference?
> 
> Thanks,
> Johan
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux