On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx> wrote: > Hi John, > > On 5/19/2018 4:49 AM, John Stultz wrote: >> In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down") >> caused the HiKey board to not correctly handle switching between >> usb-gadget and usb-host mode. >> >> Unplugging the OTG port would result in: >> [ 42.240973] dwc2 f72c0000.usb: dwc2_restore_host_registers: no host registers to restore >> [ 42.249066] dwc2 f72c0000.usb: dwc2_host_exit_hibernation: failed to restore host registers >> >> And the USB-host ports would not function. >> >> And plugging in the OTG port, we would see: >> [ 46.046557] WARNING: CPU: 3 PID: 6 at drivers/usb/dwc2/gadget.c:260 dwc2_hsotg_init_fifo+0x194/0x1a0 >> [ 46.055761] CPU: 3 PID: 6 Comm: kworker/u16:0 Not tainted 4.17.0-rc5-00030-ge67da8c #231 >> [ 46.055767] Hardware name: HiKey Development Board (DT) >> [ 46.055784] Workqueue: dwc2 dwc2_conn_id_status_change >> ... >> > Could you please send full log to debug. Full dmesg log attached. I unplugged the usb-otg port at 136 and replugged it back in at 141 >> p->uframe_sched = false; >> p->change_speed_quirk = true; >> + p->power_down = false; > > power_down declared as int, suggested to update as follow: > p->power_down = DWC2_POWER_DOWN_PARAM_NONE; > > This can be accepted as temporary solution until we will fully debug > hibernation feature for HiKey platform. Ok, will re-send with the suggested change above. thanks -john
Attachment:
dmesg.log
Description: Binary data