On Thu, May 17, 2018 at 07:03:36PM +0200, Guido Kiener wrote:
> - add ioctl USBTMC_IOCTL_API_VERSION to get current API version
> - add info message to show API version
> - replace USBTMC_TIMEOUT macros with common used USB_CTRL_GET_TIMEOUT
> or USB_CTRL_SET_TIMEOUT macros.
> - delete some superfluous code lines.
> - update ioctl-number.txt
All should be individual patches.
> @@ -2478,6 +2479,9 @@ static int usbtmc_probe(struct usb_interface *intf,
>
> dev_dbg(&intf->dev, "%s called\n", __func__);
>
> + pr_info("USBTMC driver with API version %d loaded\n",
> + USBTMC_API_VERSION);
No, please do not be noisy. Working drivers should not send any data to
the kernel log.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
