Re: [PATCH] usb: dwc2: debugfs: Don't touch RX FIFO during register dump

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/4/2018 10:09 PM, Stefan Wahren wrote:
> Dumping the registers via debugfs makes USB on Raspberry Pi completely
> unusable. The read of register GRXSTSP ("Receive Status Read and Pop
> Register") is responsible for this behaviour, because it pops the RX FIFO.
> So avoid this by omitting the relevant register.
> 
> CC: Mian Yousaf Kaukab <yousaf.kaukab@xxxxxxxxx>
> Fixes: 563cf017c443 ("usb: dwc2: debugfs: add support for complete register dump")
> Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
> ---
Acked-by: Minas Harutyunyan <hminas@xxxxxxxxxxxx>

>   drivers/usb/dwc2/debugfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c
> index 58c691f..d4c0589 100644
> --- a/drivers/usb/dwc2/debugfs.c
> +++ b/drivers/usb/dwc2/debugfs.c
> @@ -368,7 +368,7 @@ static const struct debugfs_reg32 dwc2_regs[] = {
>   	dump_register(GINTSTS),
>   	dump_register(GINTMSK),
>   	dump_register(GRXSTSR),
> -	dump_register(GRXSTSP),
> +	/* Omit GRXSTSP */
>   	dump_register(GRXFSIZ),
>   	dump_register(GNPTXFSIZ),
>   	dump_register(GNPTXSTS),
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux