On Fri, 20 Apr 2018 09:35:54 +0000 Peter Chen wrote: > > > > > > > Sorry to reply late, are you really care 2KB code side? Since many > > > users use EXTCON to handle vbus and id, it is hard just delete it. I > > > could accept patch for your specific platforms, like: > > > > > > + select EXTCON if !ARCH_XXXX > > > > The patch doesn't remove extcon support from chipidea driver. > > I just want to not select EXTCON unconditionally, but let the users choose. If the > > users need extcon, they could enable EXTCON themselves > > > > I just searched all the dts in arch/arm/boot/dts and arch/arm64/boot/dts only the four > > dts give extcon phandle to chipidea host, other users don't make use of it: > > > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > > > > arch/arm/boot/dts/qcom-apq8074-dragonboard.dts > > > > arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts > > > > arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts > > > > I see, but I do not want to break msm platforms. You may try to create Glue driver Kconfig > entry for chipidea like dwc3, and let msm depends on EXTCON. Got your points. Since multi_v7_defconfig has selected EXTCON, and EXTCON_USB_GPIO(which depends on EXTCON) is enabled in arm64 defconfig, so what about: enable EXTCON explicitly in arm64 defconfig? then add this patch? Is it acceptable? Thanks, Jisheng -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
