On Tue, Apr 17, 2018 at 11:01:41AM +0200, Hans de Goede wrote: > Hi, > > On 17-04-18 07:14, Randy Dunlap wrote: > > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > > > The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB > > Makefile does not currently build drivers/usb/common/ (where > > USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify > > the USB Makefile to always descend into drivers/usb/common/ > > to build its configured targets. > > > > Fixes these build errors: > > > > ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined! > > ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined! > > ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined! > > ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined! > > > > An alternative patch would be to select USB_COMMON in the EXTCON_AXP288 > > driver Kconfig entry, but this would build more code in > > drivers/usb/common/ than is necessary. > > Ah, that variant of fixing this got posted yesterday and I acked that, > but I agree that this version is better. > > Greg, what is your take on this fix? I'll take the patch from Arnd for this. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
