From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB Makefile does not currently build drivers/usb/common/ (where USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify the USB Makefile to always descend into drivers/usb/common/ to build its configured targets. Fixes these build errors: ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined! ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined! ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined! ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined! An alternative patch would be to select USB_COMMON in the EXTCON_AXP288 driver Kconfig entry, but this would build more code in drivers/usb/common/ than is necessary. Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> Cc: Hans de Goede <hdegoede@xxxxxxxxxx> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> Cc: linux-usb@xxxxxxxxxxxxxxx --- drivers/usb/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- lnx-417-rc1.orig/drivers/usb/Makefile +++ lnx-417-rc1/drivers/usb/Makefile @@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA) += chipidea/ obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/ obj-$(CONFIG_USB_GADGET) += gadget/ -obj-$(CONFIG_USB_COMMON) += common/ +obj-y += common/ obj-$(CONFIG_USBIP_CORE) += usbip/ -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
