Hi, Bin Liu <b-liu@xxxxxx> writes: >> Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> writes: >> >>> Bin Liu <b-liu@xxxxxx> writes: >> >>> > On Mon, Apr 09, 2018 at 02:26:14PM +0300, Felipe Balbi wrote: >> >>> >> Hi guys, >> >>> >> >> >>> >> I've been working on this series for a while now. I feels like after >> >>> >> this series the transfer management code is far easier to read and >> >>> >> understand. >> >>> >> >> >>> >> Based on my tests, I have no regressions. Tested g_mass_storage and all >> >>> >> of testusb's tests (including ISOC). >> >>> >> >> >>> >> Patches are also available on dwc3-improve-isoc-endpoints in my k.org >> >>> >> tree. Test reports would be VERY, VERY, VERY welcome. Please give this a >> >>> >> go so we avoid regressions on v4.18. >> >>> > >> >>> > Have you tested g_webcam? I just tested your dwc3-improve-isoc-endpoints >> >>> >> >>> for isoc I only tested g_zero. >> >> >> >> Then writting down details on what I observed probably won't help you :( >> >> I got webcam running here, it sure _is_ helpful to let me know how you > > Great! > >> trigger the problem ;-) Also, high-speed or super-speed? > > Both. Long story short - super-speed doesn't stream the yuv video, > gadget side kernel prints "VS request completed with status -18." > flooding messages. this means Missed Isoc. > high-speed does stream the video, but stopping the host application > (both yavta and luvcview) causes gadget side kernel prints error message > (I didn't keep the log). Then restart the host application doesn't > stream the video any more. > > To run the test: > gadget side: > # modprobe g_webcam (streaming_maxpacket=3072 for super-speed) > # uvc-gadget > host side: > $ yavta -c -f YUYV -t 1/30 -s 640x360 -n4 /dev/video1, or > $ luvcview -d /dev/video1 -f yuv running with yavta here. I see a lot of Missed Isoc. That shouldn't happen if we're just updating transfers. Perhaps the controller needs to Start Transfer per-interval? Though that would be pretty lame, I don't think that's the case. I'll debug more tomorrow. >> >>> > branch on TI VAYU evm, it has issues in both high-speed and super-speed >> >>> > connections. It works fine with v4.17-rc1. >> >>> > >> >>> > If it suppose to work with g-webcam, please let me know if you want >> >>> > the details of the problems I see - the log is very long in super-speed >> >>> > failure. >> >>> >> >>> Sure, give me some details of what's going on. Some bisection would be >> >>> great too, then I'll know which patch to blame and where to focus fixes. >> >> >> >> Roger has a copy of your previous work here: >> >> >> >> git@xxxxxxxxxx:rogerq/linux.git, branch balbi-dwc3-improve-isoc-endpoints >> >> >> >> I just tested it and it works fine with g_webcam. >> >> >> >> Do you think this information will help you? If so it saves me time on >> >> bisect ;) >> > >> > What's the SHA1 on that? I can diff it locally and see if I can find >> > problems. >> >> I got this one from Roger. There's nothing in there that should cause >> any changes to the behavior. >> >> Please capture tracepoints of both working and failing cases and send to >> me. More details at [1] > > I will try to capture the traces tomorrow. thanks -- balbi
Attachment:
signature.asc
Description: PGP signature
