Re: [PATCH] xhci: dump event ring, testpatch for Luciano

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mathias,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v4.16]
[also build test WARNING on next-20180410]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mathias-Nyman/xhci-dump-event-ring-testpatch-for-Luciano/20180410-211241
config: parisc-generic-64bit_defconfig (attached as .config)
compiler: hppa64-linux-gnu-gcc (GCC) 7.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=parisc 

All warnings (new ones prefixed by >>):

   In file included from drivers/usb/host/xhci-ring.c:58:0:
   drivers/usb/host/xhci-ring.c: In function 'xhci_dump_ev_ring':
>> drivers/usb/host/xhci-ring.c:2272:19: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
      xhci_warn(xhci, "%llx: %s\n", seg->dma + (i * sizeof(union xhci_trb)),
                      ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/host/xhci.h:1900:48: note: in definition of macro 'xhci_warn'
     dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
                                                   ^~~
   drivers/usb/host/xhci-ring.c:2278:18: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
     xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg, xhci->event_ring->dequeue));
                     ^                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/host/xhci.h:1900:48: note: in definition of macro 'xhci_warn'
     dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
                                                   ^~~

vim +2272 drivers/usb/host/xhci-ring.c

  2265	
  2266	static void xhci_dump_ev_ring(struct xhci_hcd *xhci)
  2267	{
  2268		int i;
  2269		struct xhci_segment *seg = xhci->event_ring->first_seg;
  2270	
  2271		for (i = 0; i < TRBS_PER_SEGMENT; i++) {
> 2272			xhci_warn(xhci, "%llx: %s\n", seg->dma + (i * sizeof(union xhci_trb)),
  2273				 xhci_decode_trb(seg->trbs[i].generic.field[0],
  2274						 seg->trbs[i].generic.field[1],
  2275						 seg->trbs[i].generic.field[2],
  2276						 seg->trbs[i].generic.field[3]));
  2277		}
  2278		xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg, xhci->event_ring->dequeue));
  2279	}
  2280	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux