Re: [PATCH] xhci: dump event ring, testpatch for Luciano

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mathias,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v4.16]
[also build test WARNING on next-20180410]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mathias-Nyman/xhci-dump-event-ring-testpatch-for-Luciano/20180410-211241
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 1 (different base types) @@    expected unsigned int [unsigned] [usertype] field0 @@    got igned] [usertype] field0 @@
   drivers/usb/host/xhci-ring.c:2272:17:    expected unsigned int [unsigned] [usertype] field0
   drivers/usb/host/xhci-ring.c:2272:17:    got restricted __le32 <noident>
>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 2 (different base types) @@    expected unsigned int [unsigned] [usertype] field1 @@    got igned] [usertype] field1 @@
   drivers/usb/host/xhci-ring.c:2272:17:    expected unsigned int [unsigned] [usertype] field1
   drivers/usb/host/xhci-ring.c:2272:17:    got restricted __le32 <noident>
>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 3 (different base types) @@    expected unsigned int [unsigned] [usertype] field2 @@    got igned] [usertype] field2 @@
   drivers/usb/host/xhci-ring.c:2272:17:    expected unsigned int [unsigned] [usertype] field2
   drivers/usb/host/xhci-ring.c:2272:17:    got restricted __le32 <noident>
>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 4 (different base types) @@    expected unsigned int [unsigned] [usertype] field3 @@    got igned] [usertype] field3 @@
   drivers/usb/host/xhci-ring.c:2272:17:    expected unsigned int [unsigned] [usertype] field3
   drivers/usb/host/xhci-ring.c:2272:17:    got restricted __le32 <noident>
   drivers/usb/host/xhci-ring.c:645:9: sparse: context imbalance in 'xhci_giveback_urb_in_irq' - unexpected unlock

vim +2272 drivers/usb/host/xhci-ring.c

  2265	
  2266	static void xhci_dump_ev_ring(struct xhci_hcd *xhci)
  2267	{
  2268		int i;
  2269		struct xhci_segment *seg = xhci->event_ring->first_seg;
  2270	
  2271		for (i = 0; i < TRBS_PER_SEGMENT; i++) {
> 2272			xhci_warn(xhci, "%llx: %s\n", seg->dma + (i * sizeof(union xhci_trb)),
  2273				 xhci_decode_trb(seg->trbs[i].generic.field[0],
  2274						 seg->trbs[i].generic.field[1],
  2275						 seg->trbs[i].generic.field[2],
  2276						 seg->trbs[i].generic.field[3]));
  2277		}
  2278		xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg, xhci->event_ring->dequeue));
  2279	}
  2280	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux