Re: [PATCH] USB: serial: option: reimplement interface masking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 07, 2018 at 11:54:47AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Mar 07, 2018 at 05:40:48PM +0100, Johan Hovold wrote:
> > Reimplement interface masking using device flags stored directly in the
> > device-id table. This will make it easier to add and maintain device-id
> > entries by using a more compact and readable notation compared to the
> > current implementation (which manages pairs of masks in separate
> > blacklist structs).
> > 
> > Two convenience macros are used to flag an interface as either reserved
> > or as not supporting modem-control requests:
> > 
> > 	{ USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910_DUAL_MODEM),
> > 	  .driver_info = NCTRL(0) | RSVD(3) },
> > 
> > For now, we limit the highest maskable interface number to seven, which
> > allows for (up to 16) additional device flags to be added later should
> > need arise.
> > 
> > Note that this will likely need to be backported to stable in order to
> > make future device-id backports more manageable.
> > 
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Thanks for the review. Now applied for -next.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux