Hi Stefan, On Wed, Feb 28, 2018 at 2:08 PM, Stefan Wahren <stefan.wahren@xxxxxxxx> wrote: > Hi, > > i'm not sure this is related, but i noticed something ugly in > driver/usb/chipidea/usbmisc_imx.c. > > The compatible "fsl,imx6ul-usbmisc" uses imx6sx_usbmisc_ops, which uses > usbmisc_imx6sx_init (which also calls usbmisc_imx6q_init). > Within usbmisc_imx6q_init the flag MX6_BM_NON_BURST_SETTING is enabled. > > But according to the i.MX6 ULL reference manual this bit is marked as > reserved and set to zero at reset. > > So i think it would be better to have separate imx6ul_usbmisc_ops. Yes, good catch. Peter, do you agree with this proposed change? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
