On Sun, Feb 25, 2018 at 11:18 PM, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > On Sun, Feb 25, 2018 at 08:38:33PM +0800, Kai-Heng Feng wrote: >> v2: Use in-kernel tolower() function. > > ... why are you using tolower at all? > > You've got 13 quirks already; you may need to use upper case as well > before too long. Makes sense. I'll remove tolower() in next version. > >> + quirk = vmalloc(sizeof(struct quirk_entry)); > > vmalloc? For a struct that's 24 bytes? You know that allocates an > entire 4k page, right? > Right, I'll use kmalloc() instead. Or is there any more efficient malloc function? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
