On Mon, Jan 22, 2018 at 09:07:34AM -0600, David R. Bild wrote: > On Mon, Jan 22, 2018 at 8:28 AM, Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Wed, Jan 10, 2018 at 10:58:29AM -0600, David R. Bild wrote: > > > +/** > > > + * xapea00x_spi_cleanup > > > + * > > > + * Context: !in_interrupt() > > > + */ > > > > No need to have kerneldoc formatting for static functions, nor the whole > > Context thing, but it's your code to maintain over time, not mine :) > > It's somewhat helpful for new folks on our team who need to follow the > code, although rather verbose afterwards. If you think it's too > verbose by kernel standards, I'm happy to de-kerneldoc the static > functions. No, it's fine, just not necessary at all. But note if you have them, then you need to ensure that you keep them up to date over time. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html