On Wed, Jan 10, 2018 at 10:58:29AM -0600, David R. Bild wrote:
> +/**
> + * xapea00x_spi_cleanup
> + *
> + * Context: !in_interrupt()
> + */
No need to have kerneldoc formatting for static functions, nor the whole
Context thing, but it's your code to maintain over time, not mine :)
> +static void xapea00x_spi_cleanup(struct spi_device *spi)
> +{
> + dev_dbg(&spi->dev, "%s\n", __func__);
> +}
Why? Why is this function here at all?
And don't use dev_dbg() for function calls, that's what ftrace is for.
Shouldn't you be actually cleaning up some memory or reference count
here?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
