On Thu, 9 Apr 2009, Greg KH wrote: > On Thu, Apr 09, 2009 at 10:49:49PM +0200, Guennadi Liakhovetski wrote: > > On Thu, 9 Apr 2009, Greg KH wrote: > > > > > The rename did not show up as a proper diff, you might want to > > > regenerate this. > > > > Right, it showed up not as a GNU diff, but as a git rename + diff, which, > > I thought, is a preferred way, at least for the review. > > For review, yes it is. > > I didn't realize this was a "review-only" type patch :) Well, not "only," but I certainly want it to be reviewable:-) > > Having ~2500 lines of code deleted and re-added doesn't help the > > review, I think:-) Would you prefer a "proper" GNU diff format? Can do > > that too, sure, but, perhaps, after we're done with the review. > > Although, if you use git directly, it should be now problem to git-am > > this patch. > > I would need a diff -u format to be able to apply it to the USB tree, as > I rely on quilt for my patch flow, not git, as it does not work out well > for what I need to do. > > So, after you feel comfortable with it being applied, feel free to > resend it to me in diff -u format so I can take it from there. Sure, will do, just let's give it a couple of hours:-) Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@xxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
