On Thu, Apr 09, 2009 at 10:49:49PM +0200, Guennadi Liakhovetski wrote:
> On Thu, 9 Apr 2009, Greg KH wrote:
>
> > On Thu, Apr 09, 2009 at 08:14:00PM +0200, Guennadi Liakhovetski wrote:
> > > This patch adds support for i.MX3x (only tested with i.MX31 so far) ARM
> > > SoCs to the fsl_usb2_udc driver. It also moves PHY configuration before
> > > controller reset, because otherwise an ULPI PHY doesn't get a reset and
> > > doesn't function after a reboot. The problem with longer control transfers
> > > is still not fixed. The patch renames the fsl_usb2_udc.c file to
> > > fsl_udc_core.c to preserve the same module name for user-space
> > > backwards compatibility.
> > >
> > > Signed-off-by: Guennadi Liakhovetski <lg@xxxxxxx>
> > > ---
> > >
> > > Platform bindings will be submitted later, when the ARM and MXC trees
> > > stabilise a bit for 2.6.31:-) Thanks to Sascha Hauer for the idea with
> > > the USB clock on i.MX31.
> > >
> > > drivers/usb/gadget/Kconfig | 2 +-
> > > drivers/usb/gadget/Makefile | 4 +
> > > .../usb/gadget/{fsl_usb2_udc.c => fsl_udc_core.c} | 69 +++++++++++------
> > > drivers/usb/gadget/fsl_usb2_udc.h | 18 +++++
> > > 4 files changed, 68 insertions(+), 25 deletions(-)
> > > rename drivers/usb/gadget/{fsl_usb2_udc.c => fsl_udc_core.c} (99%)
> >
> > The rename did not show up as a proper diff, you might want to
> > regenerate this.
>
> Right, it showed up not as a GNU diff, but as a git rename + diff, which,
> I thought, is a preferred way, at least for the review.
For review, yes it is.
I didn't realize this was a "review-only" type patch :)
> Having ~2500 lines of code deleted and re-added doesn't help the
> review, I think:-) Would you prefer a "proper" GNU diff format? Can do
> that too, sure, but, perhaps, after we're done with the review.
> Although, if you use git directly, it should be now problem to git-am
> this patch.
I would need a diff -u format to be able to apply it to the USB tree, as
I rely on quilt for my patch flow, not git, as it does not work out well
for what I need to do.
So, after you feel comfortable with it being applied, feel free to
resend it to me in diff -u format so I can take it from there.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
