Hi, On 1/8/2018 8:12 PM, Rob Herring wrote: > On Fri, Jan 05, 2018 at 12:14:48PM -0800, Thinh Nguyen wrote: >> DWC_usb31 periodic transfer at 48K+ bytes per interval may need >> modification to the TX/RX packet threshold to achieve optimal result. >> Add properties to make it configurable. > > I tend to think these should all be implied by the SoC specific > compatible string if they need to be tuned. > >> >> Cc: John Youn <johnyoun@xxxxxxxxxxxx> >> Signed-off-by: Thinh Nguyen <thinhn@xxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/usb/dwc3.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt >> index 52fb41046b34..02dde83d02fa 100644 >> --- a/Documentation/devicetree/bindings/usb/dwc3.txt >> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt >> @@ -55,6 +55,12 @@ Optional properties: >> - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ >> register for post-silicon frame length adjustment when the >> fladj_30mhz_sdbnd signal is invalid or incorrect. >> + - snps,rx_thr_sel_prd: set to enable periodic ESS RX packet threshold. > > Isn't the next property being present sufficient to enable this or not? Yes, we can do that. Actually, both settings must be set to enable the periodic TX/RX threshold. > >> + - snps,rx_thr_num_pkt_prd: periodic ESS RX packet threshold count. >> + - snps,rx_max_burst_prd: Max periodic ESS RX burst size. >> + - snps,tx_thr_sel_prd: set to enable periodic ESS TX packet threshold. > > ditto > >> + - snps,tx_thr_num_pkt_prd: periodic ESS TX packet threshold count. >> + - snps,tx_max_burst_prd: Max periodic ESS TX burst size. > > Don't use '_' in property names. I'll make the change. > >> >> - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated. >> >> -- >> 2.11.0 >> > Thanks, Thinh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
