On 12/31/2017 9:19 PM, Stefan Wahren wrote: Hi Stefan, >> >> Razmik Karapetyan (10): >> usb: dwc2: Set AHB burst size to INCR > > The usage hsotg->params.ahbcfg instead of the defines is a unintended fix for BCM2835. According to the BCM2835 datasheet this register have a different definition. So i like to see this split up. > This patch sets AHB burst size by default to INCR, but it can be customized later for each platform by device match table. For BSM you have dwc2_set_bcm_params() function. Patch also uses already calculated value for burst size "hsotg->params.ahbcfg" in dwc2_hsotg_core_init_disconnected() instead of calculating the same value again. What kind of problems you see here? >> usb: dwc2: Define PCGCCTL1 register in hw.h >> usb: dwc2: Define Active Clock Gating support bit in GHWCFG4 > > I think this one should be merged into the first patch which uses this define. > I am ok with this observation, i will change it. Best regards, Razmik -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
