From: Fengguang Wu <fengguang.wu@xxxxxxxxx> drivers/usb/typec/tcpm.c:4396:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 91886adfce05 ("typec: tcpm: Represent source supply through power_supply class") CC: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> --- tcpm.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/typec/tcpm.c +++ b/drivers/usb/typec/tcpm.c @@ -4393,10 +4393,7 @@ int devm_tcpm_psy_register(struct tcpm_p port->psy = devm_power_supply_register(port->dev, &port->psy_desc, &psy_cfg); - if (IS_ERR(port->psy)) - return PTR_ERR(port->psy); - - return 0; + return PTR_ERR_OR_ZERO(port->psy); } struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html