Hi Alejandro, On Fri, Dec 08, 2017 at 07:23:54PM +0000, Alejandro Mery wrote: > MUSB's davinci glue was made to depend on BROKEN by Felipe Balbi back in > 2013 because of lack of active development. needed changes were actually trivial > > Fixes: 787f5627bec8 (usb: musb: make davinci and da8xx glues depend on BROKEN) > Signed-off-by: Alejandro Mery <amery@xxxxxxxxxxxxxxxxxxx> Thanks for the effort to re-enable this driver. But due to lack of development, other than the phy and fifo mode which you try to fix with these two patches, the driver still doesn't fit in the current driver framework, for example, - the driver depends on mach/ header for CPU and board type; - clk control is not separated; - gpio control vbus should use extcon driver; So I feel it is not ready to un-broken it yet, unless others have different opinion. But I could take these two patches if not remove BROKEN from Kconfig. Regards, -Bin. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
