2017-12-11 17:14 GMT+01:00 Bart Van Assche <Bart.VanAssche@xxxxxxx>: > On Mon, 2017-12-11 at 12:24 +0100, Romain Izard wrote: >> As it reached Linus' tree with v4.15-rc3, I recently noticed the >> following commit that triggered a Kconfig request. I believe that this >> change does not make sense. >> >> 7a9618a22aa usb: gadget: allow to enable legacy drivers without USB_ETH >> >> USB_ETH was not a dependency, but a default value for the choice. As the >> choice was marked as "optional", it was possible to remove this value >> when building. >> >> After this modification, the Kconfig choice option does not contain >> anything anymore, so it is useless. It is also possible to select >> multiple built-in legacy drivers. This builds, but will not work as >> expected as only one legacy driver can be bound to an USB device >> controller at a time. > > Hello Romain, > > Sorry but it seams like I misread the drivers/usb/gadget/Kconfig file. Are > you OK with a revert of commit 7a9618a22aa? A revert or Arnd's patch, either of these is OK for me. Best regards, -- Romain Izard -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
