Hi, Romain Izard <romain.izard.pro@xxxxxxxxx> writes: > Once again, with the correct mail address. > > > ---------- Forwarded message ---------- > From: Romain Izard <romain.izard.pro@xxxxxxxxx> > Date: 2017-12-11 12:24 GMT+01:00 > Subject: Issues with 7a9618a22aa usb: gadget: allow to enable legacy > drivers without USB_ETH > To: Bart Van Assche <bart.vanassche@xxxxxxx>, Felipe Balbi > <balbi@xxxxxx>, Hannes Reinecke <hare@xxxxxxxx> > Cc : Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>, Andrzej Pietrasiewicz > <andrzej.p@xxxxxxxxxxx> > > > Hello, > > As it reached Linus' tree with v4.15-rc3, I recently noticed the > following commit that triggered a Kconfig request. I believe that this > change does not make sense. > > 7a9618a22aa usb: gadget: allow to enable legacy drivers without USB_ETH > > USB_ETH was not a dependency, but a default value for the choice. As the > choice was marked as "optional", it was possible to remove this value > when building. > > After this modification, the Kconfig choice option does not contain > anything anymore, so it is useless. It is also possible to select > multiple built-in legacy drivers. This builds, but will not work as > expected as only one legacy driver can be bound to an USB device > controller at a time. check Arnd's fix: https://marc.info/?i=20171211113048.3514863-1-arnd@xxxxxxxx -- balbi
Attachment:
signature.asc
Description: PGP signature
