On 11/29/2017 07:25 PM, Yuyang Du wrote: > Hi Shuah, > > On Tue, Nov 28, 2017 at 05:09:18PM -0700, Shuah Khan wrote: >> On 11/28/2017 11:32 AM, Shuah Khan wrote: >>> On 11/26/2017 06:33 PM, Yuyang Du wrote: >>>> Hi Juan, >>>> >>>> On Fri, Nov 24, 2017 at 12:42:22PM +0100, Juan Zea wrote: >>>>> The patch doesn't apply cleanly with the patch command, but given it is that simple I've changed it myself (I'm telling you just in case we're missing something). >>>>> >>>>> The fingerprint reader, usb stick and wacom tablet work :) >>>> >>>> Good to hear that. >>>> >>>>> I've also checked the same patch can be applied to kernel master and it works. So... is that the solution? >>>> >>>> I'll post a patch later, but before that, Hi, Shuah, does it work >>>> for you, on your test notebook? >>>> >>> >>> I am going to test this today and if it is fixes the problem on >>> my system. >>> >> >> Hi Yuyang, >> >> I tried the patch on 4.15-rc1 and looks good to me. Please send a >> proper patch to fix this. It need to go into 4.14 stable for sure. > > Thank you so much. > >> There are no more 4.13 stable releases at this time. So let's get >> this into 4.15 first and them go from there. > > Sounds good. > >> I am working on a patch for the other issue Juan reported that prevents >> finding a free-port when the first port is usb3. You don't have to worry >> about that. > > Great you take care of it. > > Hi Juan, > > Maybe you close the bug: https://bugzilla.kernel.org/show_bug.cgi?id=197867 > We have to wait for the fixes to get into the release for the bug to be closed. I wasn't sure if you will be able get the patch out soon, I worked on the driver patch as well with you as the Suggested-by: haven't sent it yet waiting to see if you can get this done. I can either send this out or wait for you get a patch out. Ether way is fine with me. vhci driver runs into the following kernel bug in vhci_urb_enqueue() BUG_ON(!urb->transfer_buffer && urb->transfer_buffer_length) This is a result of initializing sg_tablesize to ~0 during reset from vhci_setup(). Resetting sg_tablesize for the roothub conflicts with urbs in progress. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=197867 Reported-by: Juan Zea <juan.zea@xxxxxxxxxx> Suggested-by: Yuyang Du <yuyang.du@xxxxxxxxxxxxxxx> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> --- drivers/usb/usbip/vhci_hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c index 713e94170963..7c7a341f7bb9 100644 --- a/drivers/usb/usbip/vhci_hcd.c +++ b/drivers/usb/usbip/vhci_hcd.c @@ -1098,7 +1098,7 @@ static int hcd_name_to_id(const char *name) static int vhci_setup(struct usb_hcd *hcd) { struct vhci *vhci = *((void **)dev_get_platdata(hcd->self.controller)); - hcd->self.sg_tablesize = ~0; + if (usb_hcd_is_primary_hcd(hcd)) { vhci->vhci_hcd_hs = hcd_to_vhci_hcd(hcd); vhci->vhci_hcd_hs->vhci = vhci; -- 2.14.1 thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
